feat: add missing testing config keys#458
Merged
sgoudham merged 4 commits intocatppuccin:mainfrom Mar 28, 2025
Merged
Conversation
Contributor
|
Hey @dylan-robins 👋, So sorry for not continuing to engage with this. I've tested out the keys locally and made some slight modifications and they look really great. Thank you so much for working on this and apologies again for the wait on the review. I'll merge this PR as is and if you find anything else that's missing then please feel free to contribute again! |
sgoudham
approved these changes
Mar 28, 2025
Merged
Contributor
Author
|
Hey Hammy, no problem at all! Life and work get in the way, I didn't have time to chase it up with you either. Thanks for the merge, looking forward to seeing it appear in my editor in a future release 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 30 "testing.*" theme colour keys listed in vscode's documentation are not currently implemented in catppuccin-vsc, and their values seem to rely on defaults that aren't always great. In particular, this results in poor legibility of the test coverage when using an extension that implements this feature.
This PR implements these missing keys, adding them to the schema and proposing some default values for the keys. (resolves #456)
Here's some screenshots of the test coverage colouring:
Before:
After:
Important
Out of the 30 config keys, I've only made a conscious effort to make four of them look good. I'm not even sure what most of them change lol. I'll continue to look into the impact they have and report back.